D20467: Allow to close a document whose file was deleted on disk
Dominik Haumann
noreply at phabricator.kde.org
Fri Apr 12 05:49:13 BST 2019
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
INLINE COMMENTS
> katedialogs.cpp:1298
> + m_message->addAction(closeFile, false);
> + connect(closeFile, SIGNAL(triggered()), this, SIGNAL(closeTriggered()));
> +
Could you switch this to new style signal slot syntax? In a separate review request would also be fine.
REPOSITORY
R39 KTextEditor
BRANCH
arcpatch-D20467
REVISION DETAIL
https://phabricator.kde.org/D20467
To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190412/02d7a44d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list