D20477: Avoid indirection when inserting basic data

Stefan Brüns noreply at phabricator.kde.org
Fri Apr 12 01:07:18 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added a project: Baloo.
bruns requested review of this revision.

REVISION SUMMARY
  When setFileItem() is called, m_fileItems.size() is always 1, for
  setFileItems() there are always multiple elements, thus it is known which
  branch of insertBasicData() will be taken. Just call the corresponding
  target method directly, and remove the unused private insertBasicData().

TEST PLAN
  ctest

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20477

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190412/593bf1ff/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list