D20007: Add GetProcessList for retrieving the list of currently active processes

David Edmundson noreply at phabricator.kde.org
Thu Apr 11 18:52:44 BST 2019


davidedmundson added a comment.


  Looks good to me. \o/
  Hopefully a windows person can test soon.
  
  Failing that, it's near the start of the month and we have a good unit test. We can ship it and see what CI says.

INLINE COMMENTS

> kprocesslist.cpp:69
> +{
> +    d_ptr->valid = other.d_ptr->valid;
> +    d_ptr->pid = other.pid();

With the QSharedDataPointer you can delete this method.

The point of the shareddatapointer is that when you copy KProcessInfo you don't copy all the members, we just increase the internal ref-count

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190411/f092c4f9/attachment.html>


More information about the Kde-frameworks-devel mailing list