D20433: Use mount point returned from DBus instead of using property value

[Nicolas Fella]

nicolasfella added a comment.


  In D20433#447667 <https://phabricator.kde.org/D20433#447667>, @bruns wrote:
  
  > This approach is completely wrong.
  >
  > The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the property propage the signal.
  >
  > This whole "our information is inconsistent, lets query for it explicitly" dance is a mess.
  
  
  They key issue is that the PropertiesChanged signal hasn't been emitted by the time filePath() is called. We could wait for the signal there, but we don't need to since we already get the same information from the mount() call, but we just didn't use it before. That won't work if the drive is already mounted by the time solid is started, so we query the mountPoints property in that case, but that is no different to the old code.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20433

To: nicolasfella, broulik, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190411/803f9f0a/attachment.html>