D20457: [balooctl] clear command: Remove bogus check for documentData, cleanup

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Apr 11 01:54:53 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case only BasicIndexing is enabled, or when the content indexing
  is suspended due to "onBattery" mode, no data is added to the document.
  
  There is no reason to disallow clearing a file which has no data.
  
  Also remove an unused Indexer instance.

TEST PLAN
  create a file with contentIndexing disabled
  try to remove it from the index with `balooctl clear <file>`

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20457

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190411/ca51a473/attachment.html>


More information about the Kde-frameworks-devel mailing list