D20428: separe mobile text selection to avoid recursive imports

Marco Martin noreply at phabricator.kde.org
Wed Apr 10 10:31:55 BST 2019


mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  the mobile text selection toolbar uses toolbuttons, which in turn use the 
  private import. This will make the components loading stuck in dependency 
  resolution

TEST PLAN
  all loads correctly now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20428

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/MobileCursor.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/mobiletextselection/qmldir
  src/declarativeimports/plasmacomponents3/private/MobileCursor.qml
  src/declarativeimports/plasmacomponents3/private/MobileTextActionsToolBar.qml
  src/declarativeimports/plasmacomponents3/private/qmldir

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190410/143719ed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list