D19960: bluez-qt: remove warnings

David Rosca noreply at phabricator.kde.org
Tue Apr 9 18:35:45 BST 2019


drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Actually ...

INLINE COMMENTS

> a2dp-codecs.c:59
>      AAC_OBJECT_TYPE_MPEG4_AAC_SCA, */
> -    AAC_INIT_FREQUENCY(
> +    AAC_INIT_FREQUENCY((
>      /*AAC_SAMPLING_FREQ_8000 |

Why this?

> a2dp-codecs.h:135
>  #define AAC_INIT_FREQUENCY(f) \
>  	.frequency1 = (f >> 4) & 0xff, \
> +	.frequency2 = (f) & 0x0f,

Wouldn't `( (f) >> 4)` be enough instead of adding the parenthesis below?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca
Cc: ngraham, pino, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190409/2eaf2902/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list