D20366: Postpone term parsing until needed, do not set both term and searchstring

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Apr 7 21:41:47 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  `Query::toJSON()` adds both the term and searchstring to the json data
  if both are set. As setSearchString always initialized the term from
  the string, this was typically true.
  
  The executed query contained the conditions twice, and the serialized
  document was overspecified.

TEST PLAN
  ctest
  dolphin baloosearch, select e.g. "today"
  -> modified is only in the searchstring, term is not set

REPOSITORY
  R293 Baloo

BRANCH
  kio_search

REVISION DETAIL
  https://phabricator.kde.org/D20366

AFFECTED FILES
  src/lib/query.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190407/cbaea6ee/attachment.html>


More information about the Kde-frameworks-devel mailing list