D20328: [balooshow] Do not print a bogus warning for a non-indexed file
    Alexander Stippich 
    noreply at phabricator.kde.org
       
    Sun Apr  7 19:40:23 BST 2019
    
    
  
astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.
  only one minor nitpick
INLINE COMMENTS
> main.cpp:136
>  
> +                stream << "Url:" << url << "\n";
>                  stream << "GivenID: " << fid << " ActualID: " << actualFid << "\n";
Also add a space here after "Url:"?
REPOSITORY
  R293 Baloo
BRANCH
  master
REVISION DETAIL
  https://phabricator.kde.org/D20328
To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190407/4edf43ac/attachment.html>
    
    
More information about the Kde-frameworks-devel
mailing list