D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> ConfigureChecks.cmake:19
> +
> +if (LIBC_IS_GLIBC)
> +    check_cxx_source_compiles("

just do the test unconditionally

> ConfigureChecks.cmake:24
> +        int main() {
> +          int t = STATX_BASIC_STATS;
> +          return 0;

other than this define, try to do a simple usage of statx:

  struct statx buf;
  statx(AT_FDCWD, "/foo", AT_EMPTY_PATH, STATX_BASIC_STATS, &buf);

(it will not be run anyway)

> file.cpp:68
>  
> +#if HAVE_STATX && defined Q_OS_LINUX
> +#include <sys/stat.h>

no need for the Q_OS_LINUX check here

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190407/ef186ef9/attachment.html>