D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

Pino Toscano noreply at phabricator.kde.org
Sun Apr 7 11:08:22 BST 2019


pino added inline comments.

INLINE COMMENTS

> file.cpp:72-74
> +#if defined(STATX_BASIC_STATS) && defined(__GLIBC__)
> +    #define USE_STATX
> +#endif

TBH, instead of this static define, I'd do a proper cmake check (see ConfigureChecks.cmake, and config-kioslave-file.h.cmake in src/ioslaves/file).

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20096

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190407/4959bba4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list