D20328: [balooshow] Do not print a bogus warning for a non-indexed file
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Apr 6 23:07:24 BST 2019
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
balooshow allows to query file information by document id, e.g.
`balooshow 12345678`. In case the file is not indexed,
`Transaction::documentUrl(fid)` returns an empty url, and the lookup
`Baloo::filePathToId("")` returns 0. Don't print a misleading warning,
just state the file is not indexed.
TEST PLAN
`balooshow <unindexed-file-id>`
REPOSITORY
R293 Baloo
BRANCH
kio_search
REVISION DETAIL
https://phabricator.kde.org/D20328
AFFECTED FILES
src/tools/balooshow/main.cpp
To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190406/139e2cae/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list