D20315: Correct asserts/error handling in MTimeDB
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Apr 6 19:51:14 BST 2019
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, dfaure, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Mtime == 0 is valid (see commits 7842142c3288 <https://phabricator.kde.org/R293:7842142c328868837f95b5fe3aa41a2e8c48d6c0> and 628daced19b8 <https://phabricator.kde.org/R293:628daced19b88d0c537736a14aea3287a4662609>), so
remove any contradicting asserts.
Also allow a zero docId for anything but MTimeDB::put, and replace the
assert in put with a warning message. (E.g. deleting a 0 docId may be useful
for cleanup, as inserting it was possible in Release builds).
For actual errors print warning messages (instead of debug), but silence
any NOTFOUND conditions (empty ranges are a valid condition).
TEST PLAN
make (debug build)
ctest
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D20315
AFFECTED FILES
src/engine/mtimedb.cpp
To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190406/b9a3b258/attachment.html>
More information about the Kde-frameworks-devel
mailing list