D20197: Fix desktop link to file or directory

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kurlrequester.cpp:262
>      bool m_startDirCustomized;
> +    bool m_fileDialogModeWasDirFile;
>      KUrlRequester * const m_parent; // TODO: rename to 'q'

I don't understand what this variable means. What's a DirFile? ;)
Reading the rest I guess this means DirOrFile, ok, but what else is there?

> kurlrequester.cpp:452
> +            }
> +            else if (dirOrFile == fileAction) {
> +                fileDialogMode = KFile::File;

coding style: join with previous line

> kurlrequester.cpp:457
> +            }
> +            else {
> +                return;

coding style: join with previous line

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190406/ec966dac/attachment-0001.html>