D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  Looks good to me otherwise.

INLINE COMMENTS

> file.cpp:1033
> +        /* And linux version using statx syscall */
> +        if (buff.stx_btime.tv_nsec > 0) {
> +            entry.fastInsert(KIO::UDSEntry::UDS_CREATION_TIME, buff.stx_btime.tv_sec);

This check seems to be wrong with me - there can be files with legitimate zero `tv_nsec`.

Use `buff.stx_mask & STATX_BTIME` instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190406/567f5fae/attachment.html>