D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  SimpleKCM currently imposes a maximum height of `Kirigami.Units.gridUnit * 20`, which is
  arbitrary and results in many KCMs opened standalone in kcmshell still getting a scrollbar
  even when there's plenty of vertical space available.
  
  This patch changes the maximum value so that it's based on a fraction of the available
  screen height, ensuring that tall KCMs will fill the available space as often as possible.
  
  CCBUG: 398820

TEST PLAN
  No actual changes can be observed because `flickable.contentHeight` always evaluates to
  0 due to https://bugs.kde.org/show_bug.cgi?id=398820 and I haven't yet figured out the
  fix for that issue. But once that's fixed, SimpleKCM KCMs will have more sensible
  default heights when opened in kcmshell.

REPOSITORY
  R296 KDeclarative

BRANCH
  simplekcm-better-maximum-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190405/2b9fdc4e/attachment-0001.html>