D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

Alexander Stippich noreply at phabricator.kde.org
Thu Apr 4 18:07:41 BST 2019


astippich added inline comments.

INLINE COMMENTS

> propertydata.cpp:88
> +        if (it.value().isArray()) {
> +            const auto values = it.value().toArray();
> +            for (const auto val : values) {

Can you return arrays as lists here so that current behavior is unchanged, and put the behavior change into another patch so that we can merge this diff?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190404/1c98d7dc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list