D20208: Fix uninitialized memory read in KZip
Albert Astals Cid
noreply at phabricator.kde.org
Tue Apr 2 18:17:08 BST 2019
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
We were passing handledextralen instead of n to parseExtraField
We could also do a n < parseExtraField check earlier and fail, but given that parseExtraField always returns true and it has good checks for not over-reading from the buffer it seemed better just to pass n and let it parse as much as possible
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20208
AFFECTED FILES
src/kzip.cpp
To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190402/a4ef6813/attachment.html>
More information about the Kde-frameworks-devel
mailing list