D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  An icon's emblem can take up 25% of the total icon area in certain cases, which obscures enough of the icon that it may become hard to tell what it is. This is especially noticeable with 16x16 and 32x32 icons in Dolphin's Places Panel. See T9740#162147 <https://phabricator.kde.org/T9740#162147> for examples.
  
  This patch adjusts the calculation so that the emblem never takes up more then 18.75% of the total area of an icon, even at small sizes. As a result, the icons are less obscured by their emblems.

TEST PLAN
  [images go here]
  
  [images depict the new hard drive icon introduced with D15853 <https://phabricator.kde.org/D15853>]

REPOSITORY
  R302 KIconThemes

BRANCH
  smaller-emblems-at-small-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15866

AFFECTED FILES
  src/kiconloader.cpp

To: ngraham, #frameworks, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180930/4993079f/attachment-0001.html>