D15844: Allow removing non-existent folders from include and exclude lists
Nathaniel Graham
noreply at phabricator.kde.org
Sat Sep 29 23:53:04 BST 2018
ngraham created this revision.
ngraham added reviewers: Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Currently, if you add a folder to Baloo's `includeFolders` or `excludeFolders` lists, it cannot be removed again if it has been deleted. This patch fixes that for both `balooctl` and also the KCM.
TEST PLAN
mkdir ~/foobar-test
balooctl config add excludeFolders ~/foobar-test
rmdir ~/foobar-test
balooctl config remove excludeFolders ~/foobar-test
Without the patch, `balooctl` exits with an error, reports "Path does not exist", and does not remove the entry.
With the patch, `balooctl` exits cleanly with no error and removes the path
Works from the KCM, too.
REPOSITORY
R293 Baloo
BRANCH
fix-removing-locations-from-include-and-exclude-lists (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15844
AFFECTED FILES
src/tools/balooctl/configcommand.cpp
To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180929/79f85065/attachment.html>
More information about the Kde-frameworks-devel
mailing list