D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> apol wrote in documenturldb.cpp:44
> Shouldn't asserts help to find where the library is being misused?

You gain no information if you crash here. Not the code is wrong, but the processed data.

Most importantly, when somebody runs this code, compiled without DEBUG, we will run into more and more silent corruption.

As soon as baloo is in a state where it is selfhealing, adding logging becomes an option, currently it is not.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180929/f3a9f5c8/attachment.html>