D15821: fix pop up positioning for !compositing mode

Michail Vourlakos noreply at phabricator.kde.org
Sat Sep 29 06:56:42 BST 2018


mvourlakos added inline comments.

INLINE COMMENTS

> dialog.cpp:910
>      const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint))
> -            && item->window()->mask().isNull();
> +                    && !flags().testFlag(Qt::ToolTip);
>  

This positions the plasma taskmanager previews a bit out of place because plasma panels are enforcing 2px margin at their edges.

What type of window do you believe should be an exception in order for the popup to be placed according to the item that triggered it?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180929/5d0fd985/attachment.html>


More information about the Kde-frameworks-devel mailing list