D15821: fix pop up positioning for !compositing mode
Michail Vourlakos
noreply at phabricator.kde.org
Fri Sep 28 18:20:21 BST 2018
mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.
REVISION SUMMARY
--pop up positioning that was introduced in order to a dock
pop up to not be placed far for the item triggering the pop up
broke the plasma panel pop-ups placement in !compositing mode
because plasma panels are also setting a mask in !compositing
mode. This fix tries to fix the situation for plasma panels
and also keep the functionality needed by docks.
--The tooltips exception for !compositing mode is added because
docks might also want to place their tooltips not according to
window geometry or mask but according to their inner elements.
TEST PLAN
test plasma panels in compositing and !compositing in order to
confirm functionality
test Latte dock in order to confirm that popups are still placed
correctly
test Latte dock tooltips in !compositing mode in order to confirm
that can be placed inside the window or mask boundaries
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
maskPositioning
REVISION DETAIL
https://phabricator.kde.org/D15821
AFFECTED FILES
src/plasmaquick/dialog.cpp
To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180928/06ecb887/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list