D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: ngraham, anthonyfieroni.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ico files mostly contain PNGs these days which retain their image header when embedded into an ICO file, so the bits per pixel in the ICO header can be missing or incorrect. Qt still manages to extract the underlying PNG just file but the `canRead` gives up prematurely.

TEST PLAN
  I now get thumbnails for "sierra chart" exe file

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15819

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, ngraham, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180928/1497f280/attachment-0001.html>