D15644: Provide option to hide menu bar for Ksysguard

Nathaniel Graham noreply at phabricator.kde.org
Thu Sep 27 14:25:16 BST 2018


ngraham added a comment.


  Awesome job, @lsartorelli. For your next trick, would you like to create `KStandardAction::showMenubarWithWarning` (or something like that)? This would essentially duplicate the code you've written here, but it would be in a new central location so we could ensure consistency between apps, and make changes in only one place rather than //n// places. Then we could start to port KSysGuard, Kate, Gwenview to use it--and also adopt it for some of the remaining apps that don't currently show a warning, like Konsole.
  
  The relevant code is in https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619. Wanna have a go at it?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180927/097052e0/attachment.html>


More information about the Kde-frameworks-devel mailing list