D15644: Provide option to hide menu bar for Ksysguard

[Harald Sitter]

sitter added a subscriber: broulik.
sitter added inline comments.

INLINE COMMENTS

> ksysguard.cpp:148
> +  // set up 'Settings' menu
> +  mShowMenuBarAction = KStandardAction::showMenubar(this, SLOT(toggleShowMenuBar()), actionCollection());
>  

@broulik just pointed out that KStandardAction has gained support for the more modern slot syntax.

So, ideally this line should be changed to

  mShowMenuBarAction = KStandardAction::showMenubar(this, &TopLevel::toggleShowMenuBar, actionCollection());

Which has the advantage of letting the compiler assert slot compatibility, whereas the old `SLOT()` syntax turns it into a runtime problem which is easy to miss should it break in the future.

Not technically a blocking issue though.

https://wiki.qt.io/New_Signal_Slot_Syntax

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180926/707f8e05/attachment-0001.html>