D15644: Provide option to hide menu bar for Ksysguard
Nathaniel Graham
noreply at phabricator.kde.org
Tue Sep 25 17:24:31 BST 2018
ngraham added a comment.
Actually, reading over this again, is it really necessary to add a `showMessage` parameter to `toggleShowMenuBar`? In general bool-only arguments are frowned upon because they're not very readable; enums are preferred in their place. But do we even need that parameter in the first place? I don't see that it's ever even set to false anywhere.
REVISION DETAIL
https://phabricator.kde.org/D15644
To: lsartorelli, ngraham, #plasma, #frameworks
Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180925/68b2bf03/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list