D15745: Implement Media and MediaEndpoint API

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> media_p.h:35
> +
> +class MediaPrivate : public QObject
> +{

I think this needs `Q_DECL_HIDDEN`

> media_p.h:37
> +{
> +    Q_OBJECT
> +

Any particular reason this class must inherit `QObject`, you don't seem to be using `signal` or `slot` in it

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180925/ef91fa40/attachment.html>