D15714: add a string suffix to test data and use for unicode testing of taglibwriter

Sune Vuorela noreply at phabricator.kde.org
Sun Sep 23 19:56:32 BST 2018


svuorela added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:66
> ?
> The file/tags are written inside this test.

yeah. given you write and read it, if somehow it gets encoded e.g. as iso-8859-15 rather than utf8, the euro sign would be encoded as 0xa4 rather than 0x20ac.

As you write and read it in the same sequence, there is a possibiliyt for this to pass when it shouldn't.

Unfortunately roundtripping the files with bad editors can make this happen. Especially on windows.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180923/2b261ae5/attachment.html>


More information about the Kde-frameworks-devel mailing list