D15704: increase test coverage of taglibwriter

[Stefan Brüns]

bruns added a comment.


  In general this looks good, but I would like two changes:
  
  1. Do the conversion to QTest first, and leave out the change for unicode testing (e.g. `Title1` -> `Title €`)
  2. Add a third column like  "stringsuffix", and then add another test (row) for each format. `QStringLiteral("Title1")` then becomes `QStringLiteral("Title1") + stringsuffix`
  
  (2.) would go in a dependent review.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15704

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180923/1658a21c/attachment.html>