D15687: [Device Notifier] Avoid accessing attributes of stale UDIs
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Sep 22 11:51:54 BST 2018
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
When a Solid device is removed (e.g. a CD is ejected) the notifier tries
to read the attributes although the Source for the UDI has just vanished.
Fixes several QML error messages, i.e. "TypeError: Cannot read property
'...' of undefined" and "Unable to assign [undefined] to QString".
Apparently these errors also have the effect of items showing outdated
state, i.e. optical media still being shown after ejecting it.
CCBUG: 394348
TEST PLAN
1. insert optical medium
2. eject
Without the changes, the item was stuck
Now, the item is removed as soon as the medium is ejected
Also, no more errors are logged for the devicenotifier
REPOSITORY
R120 Plasma Workspace
BRANCH
device_notifier_qml_fix
REVISION DETAIL
https://phabricator.kde.org/D15687
AFFECTED FILES
applets/devicenotifier/package/contents/ui/FullRepresentation.qml
applets/devicenotifier/package/contents/ui/devicenotifier.qml
To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180922/71dbdf38/attachment.html>
More information about the Kde-frameworks-devel
mailing list