D15645: [WIP] Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu added a comment.


  Should I also add the other overloads like `createSchemeSelectionMenu` does ?

INLINE COMMENTS

> broulik wrote in kcolorschememanager.cpp:214-228
> All of this is duplicated from`createSchemeSelectionMenu`, it should be split into a separate method so it can be reused

A private function in KColorSchemeModel or a static function in kcolorschememanager.cpp ?

> broulik wrote in kcolorschememanager.h:127
> `WithDefaultEntry`?

`createSchemeSelectionMenuWithDefaultEntry` ?
won't it be too big ?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180921/aa0deee0/attachment-0001.html>