D15645: [WIP] Add scheme selection menu with a "System" entry.

Amish Naidu noreply at phabricator.kde.org
Fri Sep 21 13:26:41 BST 2018


amhndu created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
amhndu requested review of this revision.

REVISION SUMMARY
  The scheme selection menu does not offer any hint for the current system
  scheme. This also makes it hard to "reset" back to the system scheme, once
  the scheme has been changed.
  
  This is a preliminary patch to add an action which references the system scheme.
  Since, this breaks applications using the action name to save the selected
  scheme, I've made a new function in which the action data has been changed from
  only the path to the model index, this makes it possible to use the data to
  differentiate if the selection action is the system scheme action or not.
  
  I know this probably isn't the best implementation to handle it, but this is
  the best I could figure out as a quick patch to get some input on doing this
  better.

TEST PLAN
  Run `kcolorschemedemo` from `tests` and test the menu from the button.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  system-default

REVISION DETAIL
  https://phabricator.kde.org/D15645

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h
  tests/kcolorschemedemo.cpp

To: amhndu
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180921/0beb0995/attachment.html>


More information about the Kde-frameworks-devel mailing list