D15623: Finish the notification before removing it from the hash

[Harald Sitter]

sitter added a comment.


  I am not sure I understand this. (admittedly I hadn't had enough coffee yet though)
  
  NotifyByAudio doesn't own the `KNotification *`, it gets it form the outside via `::notify()`. Why would removing the entry from the internal "cache" hash m_notifications cause its deletion?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15623

To: jtamate, #frameworks, sitter
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180921/2cc94376/attachment.html>