D15623: Finish the notification before removing it from the hash

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  If the notification is deleted from the hash, when the notification::id is called later by finish, it could contain anything.
  Change the order, call finish with a valid notification pointer before removing the notification from the hash.
  
  BUG: 398695

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15623

AFFECTED FILES
  src/notifybyaudio_canberra.cpp

To: jtamate, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180920/0730f944/attachment.html>