D13315: Detect mime type of local files based on their contents

[David Faure]

dfaure added a comment.


  I agree, extensions are not reliable over HTTP, which is why mimeTypeForUrl doesn't use them for HTTP urls.
  But here we're in KFileItem, so much more likely talking about local files or FTP/SFTP/FISH/SMB/etc. where the *.php issue doesn't happen.
  
  > The case of MSWord vs. Excel is easy: Libreoffice can open both.
  
  But not e.g. calligra.
  And it's just an example, there are a LOT more. Many mimetypes just don't have any magic at all, which would mean, with this patch, that they would never get detected.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13315

To: miklosm, #frameworks, dfaure, broulik
Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180919/45dee593/attachment.html>