D15583: [Balooctl] fix directory parent check

Nathaniel Graham noreply at phabricator.kde.org
Tue Sep 18 03:18:56 BST 2018


ngraham created this revision.
ngraham added reviewers: Baloo, Dolphin, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  [Submitting this patch on behalf of James Ausmus, who attached it to https://bugs.kde.org/show_bug.cgi?id=396535 and did not respond to a request to submit it here]
  
  balooctl add includeFolders/excludeFolders was checking for parent
  directories using a startsWith string match, so directories with the
  same initial character would match - for example:
  
    $ balooctl add excludeFolders t
    $ balooctl add excludeFolders test
    Parent folder /test/kde/baloo/t is already in the list of exclude folders
  
  Fix this by appending a path separator to the path used for parent
  checking.
  
  BUG: 396535
  FIXED-IN: 5.51

TEST PLAN
  Executed the test plan from https://bugs.kde.org/show_bug.cgi?id=396535; it works now.

REPOSITORY
  R293 Baloo

BRANCH
  fix-hyphen-in-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15583

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, #dolphin, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180918/54bed865/attachment.html>


More information about the Kde-frameworks-devel mailing list