D15220: implement more basic tags for taglibwriter

[Alexander Stippich]

astippich added a comment.


  In D15220#325580 <https://phabricator.kde.org/D15220#325580>, @bruns wrote:
  
  > Can you add some Unicode exercising tests?
  
  
  I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:18
> Side note - bad implementation, see D13700 <https://phabricator.kde.org/D13700>
> 
> Also see inverse q2t in taglibwritertest.cpp

I have that on my todo list to switch to taglib's builtin functions

> bruns wrote in taglibwriter.cpp:67
> Tracknumber can be negative AFAIK, "Hidden track"

taglib only allows unsigned int for year and track, so I don't know how that's possible with taglib.
I added checks to ensure only values greater zero are written to it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15220

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180917/32eacfd6/attachment.html>