D15443: [server] Allow multiple touch interfaces per client

David Edmundson noreply at phabricator.kde.org
Mon Sep 17 11:45:47 BST 2018


davidedmundson added inline comments.

INLINE COMMENTS

> seat_interface.cpp:1332
> -        d->touchInterface.focus.touch->down(id, serial, globalPosition - d->touchInterface.focus.offset);
> -    } else if (id == 0 && focusedTouchSurface()) {
>  #if HAVE_LINUX_INPUT_H

what happened to the 
if (id == 0 )

which is making sure if you multi touch we only send the first as a mouse event.

> seat_interface.cpp:1361
> +    // note: this function may not be called after cancel,
> +    // but for performance reasons still do not assert like in touchUp case?
>      Q_D();

If you have a release build Q_ASSERT get completely compiled out and no code will run.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180917/3a060c5b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list