D15559: Python bindings: use cmake_parse_arguements, fix documentation
    Stefan Brüns 
    noreply at phabricator.kde.org
       
    Sun Sep 16 20:46:51 BST 2018
    
    
  
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
  Use of positional arguments is error prone, as e.g. switching order
  of e.g. NAMESPACE and MODULENAME wont have the desired effect, as
  the keywords are ignored for the first three arguments.
  
  Parse all arguments with cmake_parse_arguements, and fix the documentation
  (list supported arguements) and example (add TARGET keyword).
TEST PLAN
  build bindings
REPOSITORY
  R240 Extra CMake Modules
BRANCH
  python_ecm_cleanup
REVISION DETAIL
  https://phabricator.kde.org/D15559
AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake
To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180916/b2013818/attachment.html>
    
    
More information about the Kde-frameworks-devel
mailing list