D15557: Improve "insufficient disk space" error messgae
Nathaniel Graham
noreply at phabricator.kde.org
Sun Sep 16 19:50:08 BST 2018
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, Dolphin, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The prior error was misleading, and always said "Disk full." even when the disk wasn't actually full; not having enough space to move or copy the requested file doesn't mean that the disk is full! This patch re-words the error message to be clearer and still work when `errorString` is defined (as it always should be).
TEST PLAN
Before:
After:
REPOSITORY
R241 KIO
BRANCH
improve-insufficient-disk-space-error-message (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15557
AFFECTED FILES
src/core/job_error.cpp
To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180916/a3ef3c4a/attachment.html>
More information about the Kde-frameworks-devel
mailing list