D14757: Warn user before copy/move operation if available space is not enough

[Nathaniel Graham]

ngraham added a comment.


  Perfect, thanks! I did some investigation and this oddly-formed string is actually built by KIO itself, in `core/job_error.cpp`:
  
    case KIO::ERR_DISK_FULL:
        result = i18n("Could not write file %1.\nDisk full.",  errorText);
        break;
  
  It looks like `KIO::ERR_DISK_FULL` is expecting `errorText` to simply be a filename or path, and our fancier string isn't compatible with its expectations. :( It looks like in this patch, we should pass the source file/directory to `q->setErrorText()` without any fancy strings, to follow the API.
  
  However, in another patch I'd like to investigate adjusting the formatting in `core/job_error.cpp` to support fancy error messages (in particular information about required and available space, which I think is a usability improvement over just saying "disk full"), and then change all the error strings accordingly . Nearly all uses are in KIO, but one is in kio-gdrive, one is in kio-extras, and one is in plasma-framework. @what are your thoughts on this, @dfaure, @pino, or anyone else from #frameworks <https://phabricator.kde.org/tag/frameworks/>?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure, broulik, ngraham
Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180916/f71b76a0/attachment.html>