Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

[Christophe Giboudeaux]

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote:
> Hi all,
> 
> Please see below. If someone could please take a look and fix this failure
> that would be appreciated.
> 
> On another note, the Marble build recently broke with a similar error - has
> something been changed in Frameworks to remove a dependency on DBus by any
> chance?
> 
[...]
> CMake Error at lib/CMakeLists.txt:17 (add_library):
> Target "milou" links to target "Qt5::DBus" but the target was not found.
> Perhaps a find_package() call is missing for an IMPORTED target, or an
> ALIAS target is missing?

For the record, this issue was fixed yesterday. 
The problem was a change in kpackage which added Qt5::DBus to the PUBLIC 
interface link.

Milou depends on plasma-framework which depends on kpackage but nothing was 
looking for Qt5DBus.

There are different ways to avoid this kind of build issues:
- add a find_dependency() call to your FooConfig.cmake file when you add a new 
public dependency
- and before that, make sure it's not a 'PRIVATE' link target. This was the 
case here, the commit didn't change the API.