D13034: Add mechanism to notify other clients of config changes over DBus

David Faure noreply at phabricator.kde.org
Fri Sep 14 08:35:04 BST 2018


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kconfigwatcher.cpp:72
> +    watchedPaths <<QStringLiteral("/") + d->m_config->name();
> +    for (const QString file: d->m_config->additionalConfigSources()) {
> +        watchedPaths << QStringLiteral("/") + file;

const QString &

and additionalConfigSources should be put into a local const var first, to avoid a detach.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik, dfaure
Cc: dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180914/76335302/attachment.html>


More information about the Kde-frameworks-devel mailing list