D15220: implement more basic tags for taglibwriter

[Stefan Brüns]

bruns added a comment.


  Can you add some Unicode exercising tests?

INLINE COMMENTS

> taglibwritertest.cpp:18
>  
>  static QString t2q(const TagLib::String& t)
>  {

Side note - bad implementation, see D13700 <https://phabricator.kde.org/D13700>

Also see inverse q2t in taglibwritertest.cpp

> taglibwriter.cpp:67
> +    if (properties.contains(Property::TrackNumber)) {
> +        tags->setTrack(properties.value(Property::TrackNumber).toUInt());
> +    }

Tracknumber can be negative AFAIK, "Hidden track"

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15220

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180913/8967ce95/attachment-0001.html>