D13880: [KMoreTools] Reduce menu hierarchy
    Dominik Haumann 
    noreply at phabricator.kde.org
       
    Thu Sep 13 21:30:42 BST 2018
    
    
  
dhaumann added a comment.
  Almost good enough, can you remove the forward declaration again? Just another one-line change. I then don't have any objections anymore.
INLINE COMMENTS
> kmoretools.h:536
>  class KMoreToolsMenuBuilderPrivate;
> +class KmtMenuStructure;
>  
Please remove also this line again, then kmoretools.h remains completely unchanged.
REPOSITORY
  R304 KNewStuff
REVISION DETAIL
  https://phabricator.kde.org/D13880
To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180913/14f75971/attachment-0001.html>
    
    
More information about the Kde-frameworks-devel
mailing list