D15426: Avoid QByteArray::remove in AccessManagerReply::readData
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Wed Sep 12 12:28:49 BST 2018
bruns added inline comments.
INLINE COMMENTS
> accessmanagerreply_p.cpp:433
> + newData.append(data);
> + m_data = newData;
> + m_offset = 0;
if you swap these two lines (i.e. append to m_data), you have `m_data += data` in all three branches, and you can move it to the bottom.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15426
To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180912/5044dbec/attachment.html>
More information about the Kde-frameworks-devel
mailing list