D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> bruns wrote in accessmanagerreply_p.cpp:156
> Wouldn't it be better to trim the buffer in slotData, at least in the non-trivial case?

For the non-trivial case it shouldn't make a difference really. For the trivial one it does, as otherwise it would never empty m_data.

So to avoid code duplication, it's only done here.

> bruns wrote in accessmanagerreply_p.h:99
> You could use in-class initialization here ...

It's not done for the other members. I assume it's a style preference.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180911/61925450/attachment.html>