D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:943
> You should check if the value can be converted to double, and probably also if it is in a sane range.

I added the checks for a successful conversion, but in my opinion kfilemetadata should not judge if the result is within a reasonable range. This should be up to the application.

> bruns wrote in taglibextractor.cpp:50
> Can you do a followup-patch to fix this?

Yes, will do after this patch landed

REPOSITORY
  R286 KFileMetaData

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180911/464db62a/attachment.html>