D15408: Don't assert deleting the temporary file

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Change the names of the temporary files to something more difficult for other KDE programs to create.
  Remove the asserts. 
  In the very unlikely situation when the preview temporary file has been replaced by other temporary file, nothing can be done to avoid to delete the file.

TEST PLAN
  With a lot of images in the trash, while dolphin create the previews, empty the trash. (It can take a while, around 3000 images, until it asserts).
  Before: a crash in the second assert (Is a file?), because the temporary file was already deleted, therefore it is not a file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15408

AFFECTED FILES
  src/widgets/previewjob.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180910/e3aa4224/attachment.html>